Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> writes: > Hi Javier, [...] >> >> penguin in test004 is not displayed correctly. I was expecting that to be >> >> working correctly since you mentioned to be using the Linux logo on boot. >> > >> > Linux has logos for displays using 2, 16, and 256 colors. Note that the >> > default logos are 80x80, which is larger than your display, so no logo >> > is drawn. >> > Fbtest has only the full color logo, so it will look bad on a monochrome >> > display. >> >> I see. Should the test check for minimum num_colors and skip that test then? > > The test still works (you did see an ugly black-and-white penguin), doesn't it? > Fair enough. But when it defaulted to XRGB8888, it looked better. So I thought that it was a regression. No strong opinion though if the test should be skipped or not. -- Best regards, Javier Martinez Canillas Core Platforms Red Hat
