On Thursday, July 13th, 2023 at 15:17, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote: > Currently drm_client_buffer_addfb() uses the legacy drm_mode_addfb(), > which uses bpp and depth to guess the wanted buffer format. > However, drm_client_buffer_addfb() already knows the exact buffer > format, so there is no need to convert back and forth between buffer > format and bpp/depth, and the function can just call drm_mode_addfb2() > directly instead. By any chance, is the commit message wrong? The title refers to drm_mode_create_dumb(), but the description and code refer to drm_client_buffer_addfb().