Hi Tomi, Thank you for the reviews! On 16-Jun-23 18:15, Tomi Valkeinen wrote: > Hi, > > On 08/06/2023 19:37, Aradhya Bhatia wrote: >> Add support for the DSS controller on TI's AM625 SoC in the tidss >> driver. >> >> The AM625 DSS supports 2 video planes connecting to 2 video ports. >> The first plane is a full plane supporting all the features, while the >> 2nd plane is a "lite" plane without scaling support. > > The DRM planes are reversed compared to the HW planes, aren't they? Is > the above referring to HW planes? Yes, I am referring to the HW planes, and the DRM planes reversed as well. =) > >> The first video port in AM625 DSS internally provides DPI output to 2 >> OLDI transmitters. Each OLDI TX outputs 4 differential lanes of video >> output and 1 of clock output. > > I think it should be explained that OLDI is not supported in this > version, but will be added later. Okay, I will make the change. Regards Aradhya > > Other than that: > > Reviewed-by: Tomi Valkeinen <tomi.valkeinen@xxxxxxxxxxxxxxxx> > > Tomi >