On Fri, Jun 16, 2023 at 6:49 AM Linus Walleij <linus.walleij@xxxxxxxxxx> wrote: > > Hi Sarah, > > thanks for your patch! > > On Tue, Jun 13, 2023 at 5:20 PM Sarah Walker <sarah.walker@xxxxxxxxxx> wrote: > > > Add the device tree binding documentation for the Series AXE GPU used in > > TI AM62 SoCs. > > > > Signed-off-by: Sarah Walker <sarah.walker@xxxxxxxxxx> > > > +properties: > > + compatible: > > + oneOf: > > + - items: > > + - enum: > > + - ti,am62-gpu > > + - const: img,powervr-seriesaxe > > I don't see why you need to restrict the bindings to just the stuff > you happen to > be writing Linux drivers for right now. > > Add all of them! > > There is this out-of-tree binding: > https://github.com/openpvrsgx-devgroup/linux_openpvrsgx/commit/0ddd308a78926782b8a72f75c74b91417ceb9779 > > With these two on top: > https://github.com/openpvrsgx-devgroup/linux_openpvrsgx/commit/053346e1933932815066f16ebf6e6bda45d67548 > https://github.com/openpvrsgx-devgroup/linux_openpvrsgx/commit/1cb62c4cdcad096d438ee7d1d51f6001998acee3 > > They are indeed out-of-tree, but H. Nikolaus is a well-known and respected > contributor to the kernel, and I'm pretty sure he would be contributing > these upstream if he had the time and incentive. He did try[1]. Rob [1] https://lore.kernel.org/all/cover.1587760454.git.hns@xxxxxxxxxxxxx/