Hi Miquel,
On 6/9/23 16:59, Miquel Raynal wrote:
> The spi core warns us about using an of_device_id table without a
s/spi/SPI ?
> spi_device_id table aside for module utilities in orter to not rely on
s/in orter to/in order to ?
> OF modaliases. Just add this table using the device name without the
> vendor prefix (as it is usually done).
>
> Signed-off-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx>
> ---
> drivers/gpu/drm/panel/panel-sitronix-st7789v.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7789v.c
b/drivers/gpu/drm/panel/panel-sitronix-st7789v.c
> index bbc4569cbcdc..c67b9adb157f 100644
> --- a/drivers/gpu/drm/panel/panel-sitronix-st7789v.c
> +++ b/drivers/gpu/drm/panel/panel-sitronix-st7789v.c
> @@ -400,9 +400,16 @@ static const struct of_device_id
st7789v_of_match[] = {
> };
> MODULE_DEVICE_TABLE(of, st7789v_of_match);
>
> +static const struct spi_device_id st7789v_ids[] = {
> + { "st7789v", },
> + { /* sentinel */ }
> +};
> +MODULE_DEVICE_TABLE(spi, st7789v_ids);
> +
> static struct spi_driver st7789v_driver = {
> .probe = st7789v_probe,
> .remove = st7789v_remove,
> + .id_table = st7789v_ids,
> .driver = {
> .name = "st7789v",
> .of_match_table = st7789v_of_match,
May I point to you Sebastian Reichel's series that features a partial
overlap with your work? [0]
For instance, the patch at hand is comparable to [1].
Cc: Sebastian to keep him in the loop.
Best regards,
Michael
[0]
https://lore.kernel.org/dri-devel/20230422205012.2464933-1-sre@xxxxxxxxxx/
[1]
https://lore.kernel.org/dri-devel/20230422205012.2464933-4-sre@xxxxxxxxxx/
