On Sun, Jun 4, 2023 at 6:16 PM Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > On 02/06/2023 05:54, Ying Liu wrote: > > On Fri, Jun 2, 2023 at 1:45 AM Krzysztof Kozlowski > > <krzysztof.kozlowski@xxxxxxxxxx> wrote: > >> > >> On 31/05/2023 11:32, Liu Ying wrote: > >>> NXP i.MX93 mediamix blk-ctrl contains one DISPLAY_MUX register which > >>> configures parallel display format by using the "PARALLEL_DISP_FORMAT" > >>> field. Add device tree bindings for the display format configuration. > >>> > >>> Signed-off-by: Liu Ying <victor.liu@xxxxxxx> > >>> --- > >>> v1->v2: > >>> * No change. > >> > >> How did you implement Rob's comment? > > > > Should have discussed more in v1 about Rob's comment, but > > let me explain why this dt-binding makes sense here: > > "It needs to be defined as part of the mediamix blkctrl > schema though." > > Where is it defined in mediamix blkctrl? I've sent v3 patch set out to define it in mediamix blk-ctrl. Regards, Liu Ying