On Fri, Jun 2, 2023 at 1:45 AM Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > > On 31/05/2023 11:32, Liu Ying wrote: > > NXP i.MX93 mediamix blk-ctrl contains one DISPLAY_MUX register which > > configures parallel display format by using the "PARALLEL_DISP_FORMAT" > > field. Add device tree bindings for the display format configuration. > > > > Signed-off-by: Liu Ying <victor.liu@xxxxxxx> > > --- > > v1->v2: > > * No change. > > How did you implement Rob's comment? Should have discussed more in v1 about Rob's comment, but let me explain why this dt-binding makes sense here: Both i.MX8mp SoC and i.MX93 SoC media block control devices contain a LVDS Display Bridge(LDB) child device. The i.MX93 block control device additionally contains this PDFC child device. LDB dt-binding [1] is written in a separate file and referenced in i.MX8mp block control dt-binding [2]. So, for the sake of consistency, it makes sense to keep this PDFC dt-binding and reference it together with the LDB one [1] in i.MX93 block control dt-binding [3] in future, doesn't it? It seems good to have a separate PDFC dt-binding in case it can/will be referenced by multiple parent device dt-bindings. [1] Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml [2] Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.yaml [3] Documentation/devicetree/bindings/soc/imx/fsl,imx93-media-blk-ctrl.yaml Regards, Liu Ying > > > > > .../display/bridge/nxp,imx93-pdfc.yaml | 78 +++++++++++++++++++ > > 1 file changed, 78 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/display/bridge/nxp,imx93-pdfc.yaml
