On Thu, May 18, 2023 at 8:34 PM Adam Ford <aford173@xxxxxxxxx> wrote: > > On Thu, May 18, 2023 at 7:29 PM Fabio Estevam <festevam@xxxxxxxxx> wrote: > > > > Hi Adam, > > > > On Thu, May 18, 2023 at 8:06 PM Adam Ford <aford173@xxxxxxxxx> wrote: > > > > > > This series fixes the blanking pack size and the PMS calculation. It then > > > adds support to allows the DSIM to dynamically DPHY clocks, and support > > > non-burst mode while allowing the removal of the hard-coded clock values > > > for the PLL for imx8m mini/nano/plus, and it allows the removal of the > > > burst-clock device tree entry when burst-mode isn't supported by connected > > > devices like an HDMI brige. In that event, the HS clock is set to the > > > value requested by the bridge chip. > > > > > > This has been tested on both an i.MX8M Nano and i.MX8M Plus, and should > > > work on i.MX8M Mini as well. Marek Szyprowski has tested it on various > > > Exynos boards. > > > > > > Adam Ford (5): > > > drm: bridge: samsung-dsim: Fix PMS Calculator on imx8m[mnp] > > > drm: bridge: samsung-dsim: Fetch pll-clock-frequency automatically > > > drm: bridge: samsung-dsim: Select GENERIC_PHY_MIPI_DPHY > > > drm: bridge: samsung-dsim: Dynamically configure DPHY timing > > > drm: bridge: samsung-dsim: Support non-burst mode > > > > > > Lucas Stach (1): > > > drm: bridge: samsung-dsim: fix blanking packet size calculation > > > > > > drivers/gpu/drm/bridge/Kconfig | 1 + > > > drivers/gpu/drm/bridge/samsung-dsim.c | 142 +++++++++++++++++++++----- > > > include/drm/bridge/samsung-dsim.h | 4 + > > > 3 files changed, 124 insertions(+), 23 deletions(-) > > > > > > V7: Move messages indicating the optional device tree items are going > > > to be automatically read elsewhere was move to dev_dbg instead of > > > dev_info. Cleaned up some of the comments to be a bit more clear. > > > Eliminated a double variable assignement accidentally introduced > > > in V6 when some of the items were moved from patch 6 to patch 5. > > > > It seems you missed addressing one previous comment from Lucas: > > > > "Same as with the earlier patch, this needs to be documented in the DT > > binding by moving "samsung,burst-clock-frequency" to be a optional > > property." > > Aargh! > I can't believe I did that. > > Inki, > > Can I do a single patch to which references this one and have you > apply them together when the time is right, or do you want me to > resend the whole series with an additional patch at the end making the > two device tree items optional? Inki, I haven't heard back from you on whether or not you want the bindings patch to be included with me resending the series as V7 or if you're OK with a single, stand-alone patch. Will you let me know? I have the patch standing by waiting for instructions. If you're not the right person to ask, please let me know who the right person is. thanks adam > I totally forgot, and I'm sorry. > > adam > > A
