Reviewed-by: Karol Herbst <kherbst@xxxxxxxxxx> will merge soon On Mon, Apr 17, 2023 at 11:03 PM Arnd Bergmann <arnd@xxxxxxxxxx> wrote: > > From: Arnd Bergmann <arnd@xxxxxxxx> > > nv50_display_create() is declared in another header, along with > a couple of declarations that are now outdated: > > drivers/gpu/drm/nouveau/dispnv50/disp.c:2517:1: error: no previous prototype for 'nv50_display_create' > > Fixes: ba801ef068c1 ("drm/nouveau/kms: display destroy/init/fini hooks can be static") > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx> > --- > drivers/gpu/drm/nouveau/dispnv50/disp.c | 1 + > drivers/gpu/drm/nouveau/nv50_display.h | 4 +--- > 2 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/nouveau/dispnv50/disp.c b/drivers/gpu/drm/nouveau/dispnv50/disp.c > index 5bb777ff1313..9b6824f6b9e4 100644 > --- a/drivers/gpu/drm/nouveau/dispnv50/disp.c > +++ b/drivers/gpu/drm/nouveau/dispnv50/disp.c > @@ -64,6 +64,7 @@ > #include "nouveau_connector.h" > #include "nouveau_encoder.h" > #include "nouveau_fence.h" > +#include "nv50_display.h" > > #include <subdev/bios/dp.h> > > diff --git a/drivers/gpu/drm/nouveau/nv50_display.h b/drivers/gpu/drm/nouveau/nv50_display.h > index fbd3b15583bc..60f77766766e 100644 > --- a/drivers/gpu/drm/nouveau/nv50_display.h > +++ b/drivers/gpu/drm/nouveau/nv50_display.h > @@ -31,7 +31,5 @@ > #include "nouveau_reg.h" > > int nv50_display_create(struct drm_device *); > -void nv50_display_destroy(struct drm_device *); > -int nv50_display_init(struct drm_device *); > -void nv50_display_fini(struct drm_device *); > + > #endif /* __NV50_DISPLAY_H__ */ > -- > 2.39.2 >