On Tue, Apr 25, 2023 at 6:36 PM Javier Martinez Canillas <javierm@xxxxxxxxxx> wrote: > Thomas Zimmermann <tzimmermann@xxxxxxx> writes: > > > Use info->screen_buffer when reading and writing framebuffers in > > system memory. It's the correct pointer for this address space. > > > > Maybe can expand the explanation a little bit with something like this? > > "The struct fb_info has a union to store the framebuffer memory. This can > either be info->screen_base if the framebuffer is stored in I/O memory, > or info->screen_buffer if the framebuffer is stored in system memory. > > Since the fb_sys_{read,write}() functions operate on the latter address > space, it is wrong to use .screen_base and .screen_buffer must be used > instead. This also get rids of all the casting needed due not using the ... due to not ... > correct data type." +1 Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds