Hi Geert,
> -----Original Message-----
> From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Sent: Thursday, April 20, 2023 3:48 PM
> To: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> Cc: David Airlie <airlied@xxxxxxxxx>; Daniel Vetter <daniel@xxxxxxxx>; Mauro
> Carvalho Chehab <mchehab@xxxxxxxxxx>; Rob Herring <robh+dt@xxxxxxxxxx>;
> Krzysztof Kozlowski <krzk+dt@xxxxxxxxxx>; Laurent Pinchart
> <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx>; dri-
> devel@xxxxxxxxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-
> media@xxxxxxxxxxxxxxx; Geert Uytterhoeven <geert+renesas@xxxxxxxxx>; Chris
> Paterson <Chris.Paterson2@xxxxxxxxxxx>; Prabhakar Mahadev Lad
> <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>; linux-renesas-soc@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH v7 4/8] drm: rzg2l-du: Add RZ/V2L DU Support
>
> Hi Biju,
>
> On Tue, Apr 11, 2023 at 2:08 PM Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote:
> > Add support for RZ/V2L DU. The RZ/V2L DU block is identical to RZ/G2L
> > SoC.
> >
> > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> > ---
> > v7:
> > * New patch.
>
> Thanks for your patch!
>
> > --- a/drivers/gpu/drm/rcar-du/rzg2l_du_drv.c
> > +++ b/drivers/gpu/drm/rcar-du/rzg2l_du_drv.c
> > @@ -53,6 +53,7 @@ static const struct rcar_du_device_info
> > rzg2l_du_r9a07g044_info = {
> >
> > static const struct of_device_id rzg2l_du_of_table[] = {
> > { .compatible = "renesas,r9a07g044-du", .data =
> > &rzg2l_du_r9a07g044_info },
> > + { .compatible = "renesas,r9a07g054-du", .data =
> > + &rzg2l_du_r9a07g044_info },
> > { /* sentinel */ }
>
> So this change implies no fallback compatible value, OK.
I am planning to drop this patch in next version to make use of
fallback compatible as discussed in patch 6/8.
Cheers,
Biju
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like
> that.
> -- Linus Torvalds
