RE: [PATCH v7 2/8] dt-bindings: display: renesas,rzg2l-du: Document RZ/V2L DU bindings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Geert,

Thanks for the feedback.

> Subject: Re: [PATCH v7 2/8] dt-bindings: display: renesas,rzg2l-du: Document
> RZ/V2L DU bindings
> 
> Hi Biju,
> 
> On Tue, Apr 11, 2023 at 2:11 PM Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote:
> > Document DU found in RZ/V2L SoC. The DU block is identical to RZ/G2L
> > SoC and therefore use RZ/G2L fallback to avoid any driver changes.
> >
> > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> > ---
> > v7:
> >  * New patch.
> 
> Thanks for your patch!
> 
> > --- a/Documentation/devicetree/bindings/display/renesas,rzg2l-du.yaml
> > +++ b/Documentation/devicetree/bindings/display/renesas,rzg2l-du.yaml
> > @@ -16,8 +16,13 @@ description: |
> >
> >  properties:
> >    compatible:
> > -    enum:
> > -      - renesas,r9a07g044-du # RZ/G2{L,LC}
> > +    oneOf:
> > +      - enum:
> > +          - renesas,r9a07g044-du # RZ/G2{L,LC}
> > +      - items:
> > +          - enum:
> > +              - renesas,r9a07g054-vsp2    # RZ/V2L
> > +          - const: renesas,r9a07g044-vsp2 # RZ/G2L fallback
> 
> "*-vsp2", really? ;-)
> 
> And with s/vsp2/du/, it doesn't match patch 6/8, where you use
> "renesas,r9a07g054-du" without the fallback.

Oops, Typo. Copy paste error from vsp2.

OK, will use compatible r9a07g044-du as fallback in 6/8 and in driver.
as both G2L and V2L supports either DSI or DPI.

Cheers,
Biju




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux