On 18/04/2023 14:22, Brandon Cheo Fusi wrote:
> Document the 'video-mode' property for specifying the DSI video mode and update
> the example.
>
> Signed-off-by: Brandon Cheo Fusi <fusibrandon13@xxxxxxxxx>
Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.
No tests will be run here as you ignored DT list (and other entries).
Please resend.
> ---
> .../bindings/display/bridge/chipone,icn6211.yaml | 14 +++++++++++++-
> 1 file changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml b/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml
> index 5fb54375a..1f9335496 100644
> --- a/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml
> @@ -36,6 +36,16 @@ properties:
> enable-gpios:
> description: Bridge EN pin, chip is reset when EN is low.
>
> + video-mode:
Is it a common property? Lack of vendor prefix suggests it, so where
does it come from?
> + $ref: /schemas/types.yaml#/definitions/uint32
> + enum: [ 0, 1, 2 ]
> + description:
> + DSI video mode.
> + 0 - burst mode
> + 1 - non-burst mode with sync pulse
> + 2 - non-burst mode with sync event.
Why not string?
> + Defaults to 2.
default:
Don't repeat constraints in free form text.
> +
> vdd1-supply:
> description: A 1.8V/2.5V/3.3V supply that power the MIPI RX.
>
> @@ -97,7 +107,8 @@ examples:
> bridge@0 {
> compatible = "chipone,icn6211";
> reg = <0>;
> - enable-gpios = <&r_pio 0 5 GPIO_ACTIVE_HIGH>; /* LCD-RST: PL5 */
> + enable-gpios = <&r_pio 0 5 GPIO_ACTIVE_HIGH>;
Drop unrelated changes.
> + video-mode = <0>;
>
> ports {
> #address-cells = <1>;
> @@ -107,6 +118,7 @@ examples:
> reg = <0>;
>
> bridge_in_dsi: endpoint {
> + data-lanes = <1 2 3 4>;
> remote-endpoint = <&dsi_out_bridge>;
> };
> };
Best regards,
Krzysztof
