On Mon, Apr 17, 2023, at 14:56, Thomas Zimmermann wrote: > Various architectures provide <asm/fb.h> with helpers for fbdev > framebuffer devices. Share the contained code where possible. There > is already <asm-generic/fb.h>, which implements generic (as in > 'empty') functions of the fbdev helpers. The header was added in > commit aafe4dbed0bf ("asm-generic: add generic versions of common > headers"), but never used. > > Each per-architecture header file declares and/or implements fbdev > helpers and defines a preprocessor token for each. The generic > header then provides the remaining helpers. It works like the I/O > helpers in <asm/io.h>. Looks all good to me, Acked-by: Arnd Bergmann <arnd@xxxxxxxx> Arnd