As reported by Bjorn, we can end up with an unbalanced runtime PM disable count if unbind() is called before the drm device is opened (e.g. if component bind fails due to the panel driver not having been loaded yet). As runtime PM must currently stay disabled until the firmware has been loaded, fix this by making the runtime PM disable call at unbind() conditional. The rest of the series removes a bogus pm_runtime_set_active() call and drops the redundant pm_runtime_disable() from adreno_gpu_cleanup(). Included is also a related indentation cleanup. Johan Johan Hovold (4): drm/msm/adreno: fix runtime PM imbalance at unbind drm/msm/adreno: drop bogus pm_runtime_set_active() drm/msm/adreno: drop redundant pm_runtime_disable() drm/msm/adreno: clean up component ops indentation drivers/gpu/drm/msm/adreno/adreno_device.c | 10 ++++------ drivers/gpu/drm/msm/adreno/adreno_gpu.c | 5 ----- 2 files changed, 4 insertions(+), 11 deletions(-) -- 2.39.2