On Wed, 16 Nov 2022, Maxime Ripard <maxime@xxxxxxxxxx> wrote:
> On Wed, Nov 16, 2022 at 01:32:51PM +0200, Jani Nikula wrote:
>> On Wed, 16 Nov 2022, Maíra Canal <mairacanal@xxxxxxxxxx> wrote:
>> > Hi Maxime,
>> >
>> > On 11/16/22 06:17, Maxime Ripard wrote:
>> >> The MODULE_LICENSE macro is missing from the kunit helpers file, thus
>> >> leading to a build error.
>> >>
>> >> Let's introduce it along with MODULE_AUTHOR.
>> >>
>> >> Fixes: 44a3928324e9 ("drm/tests: Add Kunit Helpers")
>> >> Reported-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
>> >> Signed-off-by: Maxime Ripard <maxime@xxxxxxxxxx>
>> >
>> > It would be nice to add the SPDX-License-Identifier tag in the source
>> > file as well. Besides that,
>>
>> It's not just nice, it's basically mandatory to add license boilerplate.
>>
>> Checkpatch would've warned about this. And actually about a lot of stuff
>> in the series.
>
> Right, sorry about that. I'll send additional patches to address the
> issues already in.
>
>> (And our CI checkpatch did too, although we don't send the replies to
>> the world, just intel-gfx [1].)
>
> I'm not sure how helpful it is though if the author is not a recipient
> of the report
It actually should be, but I have absolutely no idea why in this case it
decided to do
To: "Mateusz Kwiatkowski" <kfyatek@xxxxxxxxx>
instead of you. Baffled.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
