Re: [PATCH 2/3] drm/tests: helpers: Add module infos

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Maxime,

On 11/16/22 06:17, Maxime Ripard wrote:
> The MODULE_LICENSE macro is missing from the kunit helpers file, thus
> leading to a build error.
> 
> Let's introduce it along with MODULE_AUTHOR.
> 
> Fixes: 44a3928324e9 ("drm/tests: Add Kunit Helpers")
> Reported-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
> Signed-off-by: Maxime Ripard <maxime@xxxxxxxxxx>

It would be nice to add the SPDX-License-Identifier tag in the source
file as well. Besides that,

Reviewed-by: Maíra Canal <mairacanal@xxxxxxxxxx>

Best Regards,
- Maíra Canal

> ---
>  drivers/gpu/drm/tests/drm_kunit_helpers.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/tests/drm_kunit_helpers.c b/drivers/gpu/drm/tests/drm_kunit_helpers.c
> index dbd8ec24d4be..eea450de7de8 100644
> --- a/drivers/gpu/drm/tests/drm_kunit_helpers.c
> +++ b/drivers/gpu/drm/tests/drm_kunit_helpers.c
> @@ -64,3 +64,6 @@ struct drm_device *drm_kunit_device_init(struct kunit *test, u32 features, char
>  
>  	return drm;
>  }
> +
> +MODULE_AUTHOR("Maxime Ripard <maxime@xxxxxxxxxx>");
> +MODULE_LICENSE("GPL");



[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux