On Wed, Oct 26, 2022 at 12:54:41PM -0500, Rob Herring wrote: > On Tue, Oct 25, 2022 at 08:26:13PM -0700, Bjorn Andersson wrote: > > From: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx> > > > > Add binding for the display subsystem and display processing unit in the > > Qualcomm SC8280XP platform. > > > > Signed-off-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx> > > Signed-off-by: Bjorn Andersson <quic_bjorande@xxxxxxxxxxx> > > --- > > > > Changes since v2: > > - Cleaned up description and interconnect definitions > > - Added opp-table > > > > .../bindings/display/msm/dpu-sc8280xp.yaml | 287 ++++++++++++++++++ > > 1 file changed, 287 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/display/msm/dpu-sc8280xp.yaml > > Doesn't this need to be reworked to match Dmitry's restructuring? > I based my patches on linux-next, missed Dmitry's in-flight series. Seems like this should be rebased on top of his series and hope it lands soon. Thanks, Bjorn > > > > diff --git a/Documentation/devicetree/bindings/display/msm/dpu-sc8280xp.yaml b/Documentation/devicetree/bindings/display/msm/dpu-sc8280xp.yaml > > new file mode 100644 > > index 000000000000..24e7a1562fe7 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/display/msm/dpu-sc8280xp.yaml > > @@ -0,0 +1,287 @@ > > +# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/display/msm/dpu-sc8280xp.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Qualcomm Display Processing Unit for SC8280XP > > + > > +maintainers: > > + - Bjorn Andersson <bjorn.andersson@xxxxxxxxxx> > > + > > +description: > > + Device tree bindings for MSM Mobile Display Subsystem (MDSS) that encapsulates > > + sub-blocks like DPU display controller, DSI and DP interfaces etc. > > + > > +properties: > > + compatible: > > + const: qcom,sc8280xp-mdss > > + > > + reg: > > + maxItems: 1 > > + > > + reg-names: > > + const: mdss > > + > > + power-domains: > > + maxItems: 1 > > + > > + clocks: > > + items: > > + - description: Display AHB clock from gcc > > + - description: Display AHB clock from dispcc > > + - description: Display core clock > > + > > + clock-names: > > + items: > > + - const: iface > > + - const: ahb > > + - const: core > > + > > + interrupts: > > + maxItems: 1 > > + > > + interrupt-controller: true > > + > > > + "#address-cells": true > > + > > + "#size-cells": true > > enum: [ 1, 2 ] > > (Nothing else sets that) > > Rob