Hi Maciej, thanks for your patch! On Thu, Oct 20, 2022 at 7:57 PM Maciej Kwapulinski <maciej.kwapulinski@xxxxxxxxxxxxxxx> wrote: > From: Tomasz Jankowski <tomasz1.jankowski@xxxxxxxxx> > > This is the ioctl context part of score request + "do nothing" work queue > implementation. Work queue context actual part will be added by next patch. > > signed-off-by: Tomasz Jankowski <tomasz1.jankowski@xxxxxxxxx> > Tested-by: Mikolaj Grzybowski <mikolajx.grzybowski@xxxxxxxxx> > Co-developed-by: Anisha Dattatraya Kulkarni <anisha.dattatraya.kulkarni@xxxxxxxxx> > Signed-off-by: Anisha Dattatraya Kulkarni <anisha.dattatraya.kulkarni@xxxxxxxxx> > Co-developed-by: Jianxun Zhang <jianxun.zhang@xxxxxxxxxxxxxxx> > Signed-off-by: Jianxun Zhang <jianxun.zhang@xxxxxxxxxxxxxxx> > Co-developed-by: Maciej Kwapulinski <maciej.kwapulinski@xxxxxxxxxxxxxxx> > Signed-off-by: Maciej Kwapulinski <maciej.kwapulinski@xxxxxxxxxxxxxxx> This patch start to introduce the actual work processing IIUC. So there is some funny lingo used here that should be in the commit message: - Patches - Processes - Scores These terms are used without any explanation of what it is and what the purpose is. "Patches" is especially problematic for kernel developers since we use it for our development work. Musicians may start to think about the patch cables used on an old analog synthesizer and they call the diffferent sound settings "patches" in analogy with that. In this case I suspect that "patches" in this context is unrelated to either concept and rather a new name for "computer program executing in funny processor", the same way that graphics people insist in calling their computer programs "shaders". I guess a "process" is one such "patch" executing in the accelerator? I am just guessing. I need to be explained to. If this is accepted lingo then so be it, but bums like me need to have it spelled out to understand what is going on. Some examples of patces, processes and scores will be needed in the commit message. Yours, Linus Walleij