On 10/21/2022 11:30 AM, Linus Walleij wrote: > Hi Maciej, Hi Walleij > > thanks for your patch! > > On Thu, Oct 20, 2022 at 7:57 PM Maciej Kwapulinski > <maciej.kwapulinski@xxxxxxxxxxxxxxx> wrote: > >> From: Tomasz Jankowski <tomasz1.jankowski@xxxxxxxxx> >> >> This is the ioctl context part of score request + "do nothing" work queue >> implementation. Work queue context actual part will be added by next patch. >> >> signed-off-by: Tomasz Jankowski <tomasz1.jankowski@xxxxxxxxx> >> Tested-by: Mikolaj Grzybowski <mikolajx.grzybowski@xxxxxxxxx> >> Co-developed-by: Anisha Dattatraya Kulkarni <anisha.dattatraya.kulkarni@xxxxxxxxx> >> Signed-off-by: Anisha Dattatraya Kulkarni <anisha.dattatraya.kulkarni@xxxxxxxxx> >> Co-developed-by: Jianxun Zhang <jianxun.zhang@xxxxxxxxxxxxxxx> >> Signed-off-by: Jianxun Zhang <jianxun.zhang@xxxxxxxxxxxxxxx> >> Co-developed-by: Maciej Kwapulinski <maciej.kwapulinski@xxxxxxxxxxxxxxx> >> Signed-off-by: Maciej Kwapulinski <maciej.kwapulinski@xxxxxxxxxxxxxxx> > This patch start to introduce the actual work processing IIUC. > > So there is some funny lingo used here that should be in the commit > message: > > - Patches > - Processes > - Scores patching operation here is in fact the operation of modifying the set of memory cells described by offsets (provided in score request during ioctl) with some values (also provided in the same score request during ioctl). memory cells pointed by offsets belong to memory regions (also being the part of the same score request). Score requests are put by ioctl to gna_device::request_list FIFO queue and are later processed by gna_device::request_wq work thread one by one. request_wq is the entity that sends requests to GNA device, and just before doing so it 'PATCHES' the memory in a manner described by score request. request_wq has exclusive access to GNA device. 'Score' is term taken from AI, but from the perspective above, where driver does not (have to) know what is passed to GNA device, maybe we should not use the term 'score' at all. Also, maybe 'patch' should also be renamed on something more agnostic/generic.
