Hello Thomas, On 10/11/22 15:06, Thomas Zimmermann wrote: > Hi > > Am 10.10.22 um 19:02 schrieb Javier Martinez Canillas: >> There's no need to add planes to the atomic state. Remove the call >> to drm_atomic_add_affected_planes() from simpledrm. >> >> On full modesets, the DRM helpers already add a CRTC's planes to the >> atomic state; see drm_atomic_helper_check_modeset(). There's no reason >> to call drm_atomic_add_affected_planes() unconditionally in the CRTC's >> atomic_check() in simpledrm. It's also too late, as the atomic_check() >> of the added planes will not be called before the commit. >> >> Suggested-by: Thomas Zimmermann <tzimmermann@xxxxxxx> >> Signed-off-by: Javier Martinez Canillas <javierm@xxxxxxxxxx> > > Reviewed-by: Thomas Zimmermann <tzimmermann@xxxxxxx> > Thanks. > There's also drm_atomic_add_affected_planes() in mgag200. Since you're > at it, I'd appreciate a patch. > Sure, I'll include in v2. I noticed that but didn't feel like posting a patch because I'm not familiar with that device nor have HW to test. -- Best regards, Javier Martinez Canillas Core Platforms Red Hat
