On Thu, Sep 15, 2022 at 03:25:15PM +0300, Jani Nikula wrote: > On Wed, 14 Sep 2022, Matt Roper <matthew.d.roper@xxxxxxxxx> wrote: > > Now that MTL is going to start providing two GTs, there are a few more > > places in the driver that need to iterate over each GT instead of > > operating directly on gt0. Also some more deliberate cleanup is needed, > > in cases where we fail GT/engine initialization after the first GT has > > been fully setup. > > Hijacking the thread a bit, not to be considered a blocker for this > series: > > Is there a plan to kzalloc i915->gt[0] too in intel_gt_probe_all() so we > wouldn't need to have intel_gt gt0 in struct drm_i915_private? And the > to_gt() inline would return i915->gt[0] instead of &i915->gt0? (And > maybe i915_drv.h wouldn't need the definition of intel_gt anymore! :o) Yeah, in the more medium-term I would like to dynamically allocate gt0 (and probably the primary uncore structure too) so that they don't need to be embedded into dev_priv. I'll probably wait until most of the other MTL stuff has landed and we have some CI machines setup to make sure it doesn't accidentally break anything before doing that though. Matt > > BR, > Jani. > > > > > > Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@xxxxxxxxx> > > > > Chris Wilson (1): > > drm/i915/gt: Cleanup partial engine discovery failures > > > > Tvrtko Ursulin (3): > > drm/i915: Make GEM resume all engines > > drm/i915: Make GEM suspend all GTs > > drm/i915: Handle all GTs on driver (un)load paths > > > > drivers/gpu/drm/i915/gem/i915_gem_pm.c | 33 ++++++++++++++-- > > drivers/gpu/drm/i915/gt/intel_engine_cs.c | 16 ++++++-- > > drivers/gpu/drm/i915/i915_driver.c | 3 +- > > drivers/gpu/drm/i915/i915_gem.c | 46 +++++++++++++++++------ > > 4 files changed, 78 insertions(+), 20 deletions(-) > > -- > Jani Nikula, Intel Open Source Graphics Center -- Matt Roper Graphics Software Engineer VTT-OSGC Platform Enablement Intel Corporation
