Hi Jani, On Thu, Sep 15, 2022 at 03:25:15PM +0300, Jani Nikula wrote: > On Wed, 14 Sep 2022, Matt Roper <matthew.d.roper@xxxxxxxxx> wrote: > > Now that MTL is going to start providing two GTs, there are a few more > > places in the driver that need to iterate over each GT instead of > > operating directly on gt0. Also some more deliberate cleanup is needed, > > in cases where we fail GT/engine initialization after the first GT has > > been fully setup. > > Hijacking the thread a bit, not to be considered a blocker for this > series: > > Is there a plan to kzalloc i915->gt[0] too in intel_gt_probe_all() so we > wouldn't need to have intel_gt gt0 in struct drm_i915_private? And the > to_gt() inline would return i915->gt[0] instead of &i915->gt0? (And > maybe i915_drv.h wouldn't need the definition of intel_gt anymore! :o) I had a patch that was doing that and sent it long time ago and it was rejected. I can't find it but I will check better to see what was the reason for it to be rejected. Andi
