Hi, On Thu, 8 Sep 2022 16:52:43 +0100, Stuart Menefy wrote: > VPP_WRAP_OSD1_MATRIX_COEF22.Coeff22 is documented as being bits 0-12, > not 16-28. > > Without this the output tends to have a pink hue, changing it results > in better color accuracy. > > The vendor kernel doesn't use this register. However the code which > sets VIU2_OSD1_MATRIX_COEF22 also uses bits 0-12. There is a slightly > different style of registers for configuring some of the other matrices, > which do use bits 16-28 for this coefficient, but those have names > ending in MATRIX_COEF22_30, and this is not one of those. > > [...] Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-fixes) [1/1] drm/meson: Fix OSD1 RGB to YCbCr coefficient https://cgit.freedesktop.org/drm/drm-misc/commit/?id=6463d3930ba5b6addcfc8f80a4543976a2fc7656 -- Neil
