Den 29.07.2022 18.35, skrev Maxime Ripard: > Now that the core can deal fine with analog TV modes, let's convert the > sun4i TV driver to leverage those new features. > > Signed-off-by: Maxime Ripard <maxime@xxxxxxxxxx> > > diff --git a/drivers/gpu/drm/sun4i/sun4i_tv.c b/drivers/gpu/drm/sun4i/sun4i_tv.c > index 74ff5ad6a8b9..bed52423776e 100644 > --- a/drivers/gpu/drm/sun4i/sun4i_tv.c > +++ b/drivers/gpu/drm/sun4i/sun4i_tv.c > @@ -586,8 +524,17 @@ static int sun4i_tv_bind(struct device *dev, struct device *master, > > drm_connector_attach_encoder(&tv->connector, &tv->encoder); > > + ret = drm_mode_create_tv_properties(drm, > + DRM_MODE_TV_NORM_NTSC_M | > + DRM_MODE_TV_NORM_PAL_B, > + 0, NULL); > + if (ret) > + goto err_cleanup_connector; > + Looks like you have forgotten to attach the property? Noralf. > return 0; > > +err_cleanup_connector: > + drm_connector_cleanup(&tv->connector); > err_cleanup_encoder: > drm_encoder_cleanup(&tv->encoder); > err_disable_clk: >
