Den 26.08.2022 08.46, skrev Maxime Ripard: > On Thu, Aug 25, 2022 at 02:41:27PM +0200, Noralf Trønnes wrote: >> Den 24.08.2022 17.45, skrev Maxime Ripard: >>> Hi Noralf, >>> >>> On Sat, Aug 20, 2022 at 10:18:47PM +0200, Noralf Trønnes wrote: >>>> Den 29.07.2022 18.35, skrev Maxime Ripard: >>>>> Our new tv mode option allows to specify the TV mode from a property. >>>>> However, it can still be useful, for example to avoid any boot time >>>>> artifact, to set that property directly from the kernel command line. >>>>> >>>>> Let's add some code to allow it, and some unit tests to exercise that code. >>>>> >>>>> Signed-off-by: Maxime Ripard <maxime@xxxxxxxxxx> >>>>> >>>> >>>> In the subject it says "tv_mode property", but the property is called >>>> "tv norm", so the option should be tv_norm? >>> >>> Yeah... I don't know. mode is taken but it's obviously the best name. So >>> I went with norm to avoid the (internal) conflict but I left mode for >>> the user facing property. >>> >>> I'm not sure what's best here, or maybe we can pick another name entirely? >>> >> >> Why not just call it "tv mode" or even better "TV Mode". The state >> member can be called tv_mode, but the mode_config member will need a >> temporary name until the "mode" property is removed. tv_tv_mode or maybe >> connector_tv_mode? > > Yeah, that seems like a good idea. Would legacy_tv_mode work for you? > Oh yeah, renaming the "mode" property, that works fine. Noralf.
