Hi Noralf, Thanks for your review On Mon, Aug 08, 2022 at 02:30:42PM +0200, Noralf Trønnes wrote: > Den 29.07.2022 18.34, skrev Maxime Ripard: > > The subconnector property was created by drm_mode_create_tv_properties(), > > but wasn't exposed to the userspace through the generic > > atomic_get/set_property implementation, and wasn't stored in any generic > > state structure. > > > > Let's solve this. > > > > Signed-off-by: Maxime Ripard <maxime@xxxxxxxxxx> > > I just realised that this and the select_subconnector property isn't > used by any drivers. Do you plan to use them? Maybe they don't need to > be wired up at all. I'm not sure really It's true that the subconnector and select_subconnector fields in the TV connector state aren't used by any driver, but the ch7006 and nouveau will update the property content through a call to drm_object_property_set_value https://elixir.bootlin.com/linux/latest/source/drivers/gpu/drm/i2c/ch7006_drv.c#L217 https://elixir.bootlin.com/linux/latest/source/drivers/gpu/drm/nouveau/dispnv04/tvnv17.c#L185 I think it could still be useful to report it in the connector state, if only for consistency? Maxime
Attachment:
signature.asc
Description: PGP signature
