On Sun, 24 Jul 2022 at 22:51, Javier Martinez Canillas <javierm@xxxxxxxxxx> wrote: > > On 7/24/22 20:47, Javier Martinez Canillas wrote: > > Hello Dmitry, > > [...] > > >> Now there is no point in having this as a separate function. Could you > > > > The only reason why I kept this was to avoid duplicating the same comment > > in two places. I thought that an inline function would be better than that. > > > >> please inline it? > >> > > Or do you mean inline it as dropping the wrapper helper and just call to > drm_atomic_helper_shutdown() in both callbacks ? I'm OK with that but as > mentioned then we should probably have to duplicate the comment. > > Since is marked as inline anyways, the resulting code should be the same. Yes, I'd like for you to drop the wrapper. I'm fine with duplicating the comment, since it will be in place where it matters (before checking ddev->registered) rather than just stating the contract for the wrapper (which can be easily ignored). (And yes, I do read patches and commit messages before commenting.) -- With best wishes Dmitry
