On 7/24/22 20:47, Javier Martinez Canillas wrote: > Hello Dmitry, [...] >> Now there is no point in having this as a separate function. Could you > > The only reason why I kept this was to avoid duplicating the same comment > in two places. I thought that an inline function would be better than that. > >> please inline it? >> Or do you mean inline it as dropping the wrapper helper and just call to drm_atomic_helper_shutdown() in both callbacks ? I'm OK with that but as mentioned then we should probably have to duplicate the comment. Since is marked as inline anyways, the resulting code should be the same. -- Best regards, Javier Martinez Canillas Linux Engineering Red Hat
