On Wed, 2022-07-06 at 16:20 +0200, Matthias Brugger wrote:
>
> On 01/07/2022 05:15, xinlei.lee@xxxxxxxxxxxx wrote:
> > From: Xinlei Lee <xinlei.lee@xxxxxxxxxxxx>
> >
> > Add mmsys func to manipulate dpi output format config for MT8186.
> >
> > Signed-off-by: Jitao Shi <jitao.shi@xxxxxxxxxxxx>
> > Signed-off-by: Xinlei Lee <xinlei.lee@xxxxxxxxxxxx>
> > ---
> > drivers/soc/mediatek/mt8186-mmsys.h | 1 +
> > drivers/soc/mediatek/mtk-mmsys.c | 8 ++++++++
> > include/linux/soc/mediatek/mtk-mmsys.h | 2 ++
> > 3 files changed, 11 insertions(+)
> >
> > diff --git a/drivers/soc/mediatek/mt8186-mmsys.h
> > b/drivers/soc/mediatek/mt8186-mmsys.h
> > index eb1ad9c37a9c..0b450b00b829 100644
> > --- a/drivers/soc/mediatek/mt8186-mmsys.h
> > +++ b/drivers/soc/mediatek/mt8186-mmsys.h
> > @@ -3,6 +3,7 @@
> > #ifndef __SOC_MEDIATEK_MT8186_MMSYS_H
> > #define __SOC_MEDIATEK_MT8186_MMSYS_H
> >
> > +#define MT8186_MMSYS_DUMMY0 0X400
>
> I don't have access to the datasheet, but I really wonder if it's
> really called
> dummy0. If so, you would need to explain in more detail in the commit
> message.
>
> Regards,
> Matthias
>
> > #define MT8186_MMSYS_OVL_CON 0xF04
> > #define MT8186_MMSYS_OVL0_CON_MASK 0x3
> > #define MT8186_MMSYS_OVL0_2L_CON_MASK 0xC
> > diff --git a/drivers/soc/mediatek/mtk-mmsys.c
> > b/drivers/soc/mediatek/mtk-mmsys.c
> > index 2b0b805c65dd..de3f11cb931f 100644
> > --- a/drivers/soc/mediatek/mtk-mmsys.c
> > +++ b/drivers/soc/mediatek/mtk-mmsys.c
> > @@ -252,6 +252,14 @@ void mtk_mmsys_ddp_disconnect(struct device
> > *dev,
> > }
> > EXPORT_SYMBOL_GPL(mtk_mmsys_ddp_disconnect);
> >
> > +void mtk_mmsys_ddp_dpi_confing(struct device *dev, u32 mask, u32
> > val,
> > + struct cmdq_pkt *cmdq_pkt)
> > +{
> > + mtk_mmsys_update_bits(dev_get_drvdata(dev),
> > MT8186_MMSYS_DUMMY0, mask,
> > + val, cmdq_pkt);
> > +}
> > +EXPORT_SYMBOL_GPL(mtk_mmsys_ddp_dpi_confing);
> > +
> > void mtk_mmsys_merge_async_config(struct device *dev, int idx,
> > int width, int height,
> > struct cmdq_pkt *cmdq_pkt)
> > {
> > diff --git a/include/linux/soc/mediatek/mtk-mmsys.h
> > b/include/linux/soc/mediatek/mtk-mmsys.h
> > index 343e093f0fc3..40c538c0664b 100644
> > --- a/include/linux/soc/mediatek/mtk-mmsys.h
> > +++ b/include/linux/soc/mediatek/mtk-mmsys.h
> > @@ -90,4 +90,6 @@ void mtk_mmsys_mixer_in_config(struct device
> > *dev, int idx, bool alpha_sel, u16
> > void mtk_mmsys_mixer_in_channel_swap(struct device *dev, int idx,
> > bool channel_swap,
> > struct cmdq_pkt *cmdq_pkt);
> >
> > +void mtk_mmsys_ddp_dpi_confing(struct device *dev, u32 mask, u32
> > val,
> > + struct cmdq_pkt *cmdq_pkt);
> > #endif /* __MTK_MMSYS_H */
Hi Matthias
Thank you for your suggestion.
I'm sorry for not explaining what this register does in detail, I'll
explain it in the next commit message.
Best Regards!
xinlei
