Hi Samuel,
On Sun, Jul 3, 2022 at 1:17 PM Samuel Holland <samuel@xxxxxxxxxxxx> wrote:
On 6/15/22 4:38 AM, Suniel Mahesh wrote:
> Add a binding for the RenewWorldOutReach R16-Vista-E board based on
> allwinner R16.
>
> Signed-off-by: Christopher Vollo <chris@xxxxxxxxxxxxxxxxx>
> Signed-off-by: Jagan Teki <jagan@xxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Suniel Mahesh <sunil@xxxxxxxxxxxxxxxxxxxx>
The primary author of the commit (the From:) should be the first signer, unless
you are using Co-developed-by:. See the examples here:
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by
> ---
> Changes for v2:
> - Add missing compatible string
> - insert missing signatures of contributors
> ---
> Documentation/devicetree/bindings/arm/sunxi.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documentation/devicetree/bindings/arm/sunxi.yaml
> index 95278a6a9a8e..52b8c9aba6f3 100644
> --- a/Documentation/devicetree/bindings/arm/sunxi.yaml
> +++ b/Documentation/devicetree/bindings/arm/sunxi.yaml
> @@ -787,6 +787,12 @@ properties:
> - const: allwinner,r7-tv-dongle
> - const: allwinner,sun5i-a10s
>
> + - description: RenewWorldOutreach R16-Vista-E
> + items:
> + - const: renewworldoutreach,r16-vista-e
This vendor prefix should be documented.
Thanks for the suggestions, sending a v3.
Regards,
Samuel
> + - const: allwinner,sun8i-r16
> + - const: allwinner,sun8i-a33
> +
> - description: RerVision H3-DVK
> items:
> - const: rervision,h3-dvk
>
