Quoting Dmitry Baryshkov (2022-07-07 20:59:02) > On 08/07/2022 04:32, Stephen Boyd wrote: > > Quoting Dmitry Baryshkov (2022-07-07 14:32:00) > >> diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > >> index f00eae66196f..1ef845005b14 100644 > >> --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > >> +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > >> @@ -119,6 +111,50 @@ required: > >> - power-domains > >> - ports > >> > >> +allOf: > >> + - if: > >> + properties: > >> + compatible: > >> + contains: > >> + enum: > >> + - qcom,sc7280-edp > >> + then: > >> + properties: > >> + clocks: > >> + items: > >> + - description: XO clock > > > > What is this for? I would guess it's for the eDP phy, but that isn't > > part of the eDP controller, so probably it can be removed. > > Good question. I was documenting what is present in the sc7280-edp > controller DT entry. Could you please check if we can drop them? I don't > have the hardware at hand. > eDP works fine without those two clks on CRD (hoglin). They can be dropped from the dtsi file.