Re: [PATCH 5/9] dt-bindings: msm/dp: account for clocks specific for qcom,sc7280-edp

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 08/07/2022 04:32, Stephen Boyd wrote:
Quoting Dmitry Baryshkov (2022-07-07 14:32:00)
diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
index f00eae66196f..1ef845005b14 100644
--- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
@@ -119,6 +111,50 @@ required:
    - power-domains
    - ports

+allOf:
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - qcom,sc7280-edp
+    then:
+      properties:
+        clocks:
+          items:
+            - description: XO clock

What is this for? I would guess it's for the eDP phy, but that isn't
part of the eDP controller, so probably it can be removed.

Good question. I was documenting what is present in the sc7280-edp controller DT entry. Could you please check if we can drop them? I don't have the hardware at hand.


+            - description: eDP reference clock

Same for this one, looking at the binding for qcom,sc7280-edp-phy. Can
we simply remove these two clks from sc7280? I think it will be fine.


--
With best wishes
Dmitry



[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux