On Thu, 30 Jun 2022 at 19:40, Marek Vasut <marex@xxxxxxx> wrote:
>
> The DE inversion is implemented in LCDIFv3 driver and is no longer
> needed in the LDB bridge which does not invert the DE signal. Drop
> the inversion.
>
> Fixes: 463db5c2ed4ae ("drm: bridge: ldb: Implement simple Freescale i.MX8MP LDB bridge")
> Signed-off-by: Marek Vasut <marex@xxxxxxx>
> Cc: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> Cc: Lucas Stach <l.stach@xxxxxxxxxxxxxx>
> Cc: Maxime Ripard <maxime@xxxxxxxxxx>
> Cc: Peng Fan <peng.fan@xxxxxxx>
> Cc: Robby Cai <robby.cai@xxxxxxx>
> Cc: Robert Foss <robert.foss@xxxxxxxxxx>
> Cc: Sam Ravnborg <sam@xxxxxxxxxxxx>
> Cc: Thomas Zimmermann <tzimmermann@xxxxxxx>
> To: dri-devel@xxxxxxxxxxxxxxxxxxxxx
> ---
> drivers/gpu/drm/bridge/fsl-ldb.c | 17 -----------------
> 1 file changed, 17 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/fsl-ldb.c b/drivers/gpu/drm/bridge/fsl-ldb.c
> index b2675c769a550..10077d4aed358 100644
> --- a/drivers/gpu/drm/bridge/fsl-ldb.c
> +++ b/drivers/gpu/drm/bridge/fsl-ldb.c
> @@ -74,22 +74,6 @@ static int fsl_ldb_attach(struct drm_bridge *bridge,
> bridge, flags);
> }
>
> -static int fsl_ldb_atomic_check(struct drm_bridge *bridge,
> - struct drm_bridge_state *bridge_state,
> - struct drm_crtc_state *crtc_state,
> - struct drm_connector_state *conn_state)
> -{
> - /* Invert DE signal polarity. */
> - bridge_state->input_bus_cfg.flags &= ~(DRM_BUS_FLAG_DE_LOW |
> - DRM_BUS_FLAG_DE_HIGH);
> - if (bridge_state->output_bus_cfg.flags & DRM_BUS_FLAG_DE_LOW)
> - bridge_state->input_bus_cfg.flags |= DRM_BUS_FLAG_DE_HIGH;
> - else if (bridge_state->output_bus_cfg.flags & DRM_BUS_FLAG_DE_HIGH)
> - bridge_state->input_bus_cfg.flags |= DRM_BUS_FLAG_DE_LOW;
> -
> - return 0;
> -}
> -
> static void fsl_ldb_atomic_enable(struct drm_bridge *bridge,
> struct drm_bridge_state *old_bridge_state)
> {
> @@ -241,7 +225,6 @@ fsl_ldb_mode_valid(struct drm_bridge *bridge,
>
> static const struct drm_bridge_funcs funcs = {
> .attach = fsl_ldb_attach,
> - .atomic_check = fsl_ldb_atomic_check,
> .atomic_enable = fsl_ldb_atomic_enable,
> .atomic_disable = fsl_ldb_atomic_disable,
> .atomic_duplicate_state = drm_atomic_helper_bridge_duplicate_state,
> --
> 2.35.1
>
Reviewed-by: Robert Foss <robert.foss@xxxxxxxxxx>
Applied to drm-misc-next.
