Hi, Bo-Chen: On Mon, 2022-06-27 at 16:03 +0800, Bo-Chen Chen wrote: > From: Markus Schneider-Pargmann <msp@xxxxxxxxxxxx> > > This patch adds a embedded displayport driver for the MediaTek mt8195 > SoC. > > It supports the MT8195, the embedded DisplayPort units. It offers > DisplayPort 1.4 with up to 4 lanes. > > The driver creates a child device for the phy. The child device will > never exist without the parent being active. As they are sharing a > register range, the parent passes a regmap pointer to the child so > that > both can work with the same register range. The phy driver sets > device > data that is read by the parent to get the phy device that can be > used > to control the phy properties. > > This driver is based on an initial version by > Jitao shi <jitao.shi@xxxxxxxxxxxx> > > Signed-off-by: Markus Schneider-Pargmann <msp@xxxxxxxxxxxx> > Signed-off-by: Guillaume Ranquet <granquet@xxxxxxxxxxxx> > [Bo-Chen: Cleanup the drivers and modify comments from reviewers] > Signed-off-by: Bo-Chen Chen <rex-bc.chen@xxxxxxxxxxxx> > --- [snip] > + > +static int link_rate_to_mb_per_s(struct mtk_dp *mtk_dp, u32 > linkrate) > +{ > + switch (linkrate) { > + case DP_LINK_BW_1_62: > + return 1620; > + case DP_LINK_BW_2_7: > + return 2700; > + case DP_LINK_BW_5_4: > + return 5400; > + case DP_LINK_BW_8_1: > + return 8100; > + default: > + drm_err(mtk_dp->drm_dev, > + "Implementation error, unknown linkrate %d\n", > + linkrate); > + return -EINVAL; > + } > +} It looks like this function is equal to drm_dp_bw_code_to_link_rate(), so remove this function and use drm_dp_bw_code_to_link_rate(). Regards, CK