Applied. Thanks! On Tue, Jun 28, 2022 at 5:46 AM Mauro Carvalho Chehab <mchehab@xxxxxxxxxx> wrote: > > There are 4 undocumented fields at struct amdgpu_display_manager. > > Add documentation for them, fixing those warnings: > > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:544: warning: Function parameter or member 'dmub_outbox_params' not described in 'amdgpu_display_manager' > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:544: warning: Function parameter or member 'num_of_edps' not described in 'amdgpu_display_manager' > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:544: warning: Function parameter or member 'disable_hpd_irq' not described in 'amdgpu_display_manager' > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:544: warning: Function parameter or member 'dmub_aux_transfer_done' not described in 'amdgpu_display_manager' > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:544: warning: Function parameter or member 'delayed_hpd_wq' not described in 'amdgpu_display_manager' > > Signed-off-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx> > --- > > To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. > See [PATCH 00/22] at: https://lore.kernel.org/all/cover.1656409369.git.mchehab@xxxxxxxxxx/ > > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h > index 547fc1547977..73755b304299 100644 > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h > @@ -242,6 +242,13 @@ struct hpd_rx_irq_offload_work { > * @force_timing_sync: set via debugfs. When set, indicates that all connected > * displays will be forced to synchronize. > * @dmcub_trace_event_en: enable dmcub trace events > + * @dmub_outbox_params: DMUB Outbox parameters > + * @num_of_edps: number of backlight eDPs > + * @disable_hpd_irq: disables all HPD and HPD RX interrupt handling in the > + * driver when true > + * @dmub_aux_transfer_done: struct completion used to indicate when DMUB > + * transfers are done > + * @delayed_hpd_wq: work queue used to delay DMUB HPD work > */ > struct amdgpu_display_manager { > > -- > 2.36.1 >
