On Sat, 25 Jun 2022, Sam Ravnborg <sam@xxxxxxxxxxxx> wrote:
> Hi Kevin,
>
> A few nitpicks in the following.
>
> Sam
>
> On Fri, Jun 24, 2022 at 03:26:09PM -0500, Kevin Brace wrote:
>> +typedef struct _via_lvds_info {
>> + u32 x;
>> + u32 y;
>> +} via_lvds_info;
> Make this look like:
> typedef struct via_lvds_info {
> u32 x;
> u32 y;
> };
>
> This follows the normal linux way, and there is only one user anyway.
The normal linux way would be to *not* use typedefs in the first
place. ;)
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
