Hi Angelo,
Yes, I missed that!
So just forget about this patch and use yours.
Thanks for your help :)
Regard,
Jason-JH.Lin
On Wed, 2022-06-22 at 15:31 +0200, AngeloGioacchino Del Regno wrote:
> Il 22/06/22 15:19, Jason-JH.Lin ha scritto:
> > Add suffix 0 to DDP_COMPONENT_DITHER for mt8395.
> >
> > Fixes: 141311b856d8 ("soc: mediatek: mutex: add MT8365 support")
> > Signed-off-by: Jason-JH.Lin <jason-jh.lin@xxxxxxxxxxxx>
>
>
> Hello Jason-JH,
>
> you must've missed my commit, sent two days ago, which is doing the
> same:
>
>
https://lore.kernel.org/lkml/20220620102454.131417-1-angelogioacchino.delregno@xxxxxxxxxxxxx/T/#u
>
> Anyway, I have avoided to rename the definition, as from what I
> understand
> MT8365 has only one dither mod and that's called "DITHER", not
> "DITHER0"...
> ...but I've added the suffix to the array assignment, as that's what
> we have
> in the enumeration.
>
> I think that #define MT8365_MUTEX_MOD_DISP_DITHER should be kept as-
> is.
>
> Also... this commit is not fixing anything, as it was already working
> before,
> so the Fixes tag shouldn't be present.
>
> Regards,
> Angelo
>
> > ---
> > drivers/soc/mediatek/mtk-mutex.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/soc/mediatek/mtk-mutex.c
> > b/drivers/soc/mediatek/mtk-mutex.c
> > index fa8e0ba38803..3b25fd6b91aa 100644
> > --- a/drivers/soc/mediatek/mtk-mutex.c
> > +++ b/drivers/soc/mediatek/mtk-mutex.c
> > @@ -130,7 +130,7 @@
> > #define MT8365_MUTEX_MOD_DISP_CCORR 13
> > #define MT8365_MUTEX_MOD_DISP_AAL 14
> > #define MT8365_MUTEX_MOD_DISP_GAMMA 15
> > -#define MT8365_MUTEX_MOD_DISP_DITHER 16
> > +#define MT8365_MUTEX_MOD_DISP_DITHER0 16
> > #define MT8365_MUTEX_MOD_DISP_DSI0 17
> > #define MT8365_MUTEX_MOD_DISP_PWM0 20
> > #define MT8365_MUTEX_MOD_DISP_DPI0 22
> > @@ -358,7 +358,7 @@ static const unsigned int
> > mt8365_mutex_mod[DDP_COMPONENT_ID_MAX] = {
> > [DDP_COMPONENT_AAL0] = MT8365_MUTEX_MOD_DISP_AAL,
> > [DDP_COMPONENT_CCORR] = MT8365_MUTEX_MOD_DISP_CCORR,
> > [DDP_COMPONENT_COLOR0] = MT8365_MUTEX_MOD_DISP_COLOR0,
> > - [DDP_COMPONENT_DITHER] = MT8365_MUTEX_MOD_DISP_DITHER,
> > + [DDP_COMPONENT_DITHER0] = MT8365_MUTEX_MOD_DISP_DITHER0,
> > [DDP_COMPONENT_DPI0] = MT8365_MUTEX_MOD_DISP_DPI0,
> > [DDP_COMPONENT_DSI0] = MT8365_MUTEX_MOD_DISP_DSI0,
> > [DDP_COMPONENT_GAMMA] = MT8365_MUTEX_MOD_DISP_GAMMA,
>
>
--
Jason-JH Lin <jason-jh.lin@xxxxxxxxxxxx>
