On Fri, 10 Jun 2022 09:03:15 +0200 Thomas Zimmermann <tzimmermann@xxxxxxx> wrote: > Hi > > Am 09.06.22 um 23:44 schrieb Alex Williamson: > > On Thu, 9 Jun 2022 15:41:02 -0600 > > Alex Williamson <alex.williamson@xxxxxxxxxx> wrote: > > > >> On Thu, 9 Jun 2022 11:13:22 +0200 > >> Thomas Zimmermann <tzimmermann@xxxxxxx> wrote: > >>> > >>> Please have a look at the attached patch. It moves the aperture helpers > >>> to a location common to the various possible users (DRM, fbdev, vfio). > >>> The DRM interfaces remain untouched for now. The patch should provide > >>> what you need in vfio and also serve our future use cases for graphics > >>> drivers. If possible, please create your patch on top of it. > >> > >> Looks good to me, this of course makes the vfio change quite trivial. > >> One change I'd request: > >> > >> diff --git a/drivers/video/console/Kconfig b/drivers/video/console/Kconfig > >> index 40c50fa2dd70..7f3c44e1538b 100644 > >> --- a/drivers/video/console/Kconfig > >> +++ b/drivers/video/console/Kconfig > >> @@ -10,6 +10,7 @@ config VGA_CONSOLE > >> depends on !4xx && !PPC_8xx && !SPARC && !M68K && !PARISC && !SUPERH && \ > >> (!ARM || ARCH_FOOTBRIDGE || ARCH_INTEGRATOR || ARCH_NETWINDER) && \ > >> !ARM64 && !ARC && !MICROBLAZE && !OPENRISC && !S390 && !UML > >> + select APERTURE_HELPERS if (DRM || FB || VFIO_PCI) > >> default y > >> help > >> Saying Y here will allow you to use Linux in text mode through a > >> > >> This should be VFIO_PCI_CORE. Thanks, > > I attached an updated patch to this email. > > > > > Also, whatever tree this lands in, I'd appreciate a topic branch being > > made available so I can more easily get the vfio change in on the same > > release. Thanks, > > You can add my patch to your series and merge it through vfio. You'd > only have to cc dri-devel for the patch's review. I guess it's more > important for vfio than DRM. We have no hurry on the DRM side, but v5.20 > would be nice. Ok, I didn't realize you were offering the patch for me to post and merge. I'll do that. Thanks! Alex
