Hi, > You shouldn't have to copy any of the implementation of the aperture > helpers. That comes from the aperture helpers being part of drm ... > For patch 2, the most trivial workaround is to instanciate struct drm_driver > here and set the name field to 'vdev->vdev.ops->name'. In the longer term, > the aperture helpers will be moved out of DRM and into a more prominent > location. That workaround will be cleaned up then. ... but if the long-term plan is to clean that up properly anyway I don't see the point in bike shedding too much on the details of some temporary solution. > Alternatively, drm_aperture_remove_conflicting_pci_framebuffers() could be > changed to accept the name string as second argument, but that's quite a bit > of churn within the DRM code. Also pointless churn because you'll have the very same churn again when moving the aperture helpers out of drm. take care, Gerd
