On Tue, May 10, 2022 at 12:15:29PM -0500, Rob Herring wrote: > On Tue, May 10, 2022 at 09:09:12AM +0200, Sascha Hauer wrote: > > The VOP2 driver relies on reg-names properties, but these are not > > documented. Add the missing documentation, make reg-names mandatory > > and increase minItems to 2 as always both register spaces are needed. > > > > Signed-off-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> > > --- > > .../bindings/display/rockchip/rockchip-vop2.yaml | 8 +++++++- > > 1 file changed, 7 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml > > index 655d9b327f7d3..7238cdec9eb8a 100644 > > --- a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml > > +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml > > @@ -22,7 +22,7 @@ properties: > > - rockchip,rk3568-vop > > > > reg: > > - minItems: 1 > > + minItems: 2 > > You ran the dt checks, right? Well, almost... I did run dtbs_check, but I should have ran dt_binding_check. > This should give you a warning. The > correct thing is drop minItems if there's always 2 entries. Indeed this gives me a warning. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
