On Tue, May 10, 2022 at 09:09:12AM +0200, Sascha Hauer wrote: > The VOP2 driver relies on reg-names properties, but these are not > documented. Add the missing documentation, make reg-names mandatory > and increase minItems to 2 as always both register spaces are needed. > > Signed-off-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> > --- > .../bindings/display/rockchip/rockchip-vop2.yaml | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml > index 655d9b327f7d3..7238cdec9eb8a 100644 > --- a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml > +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml > @@ -22,7 +22,7 @@ properties: > - rockchip,rk3568-vop > > reg: > - minItems: 1 > + minItems: 2 You ran the dt checks, right? This should give you a warning. The correct thing is drop minItems if there's always 2 entries. > items: > - description: > Must contain one entry corresponding to the base address and length > @@ -31,6 +31,11 @@ properties: > Can optionally contain a second entry corresponding to > the CRTC gamma LUT address. > > + reg-names: > + items: > + - const: vop > + - const: gamma-lut > + > interrupts: > maxItems: 1 > description: > @@ -86,6 +91,7 @@ properties: > required: > - compatible > - reg > + - reg-names > - interrupts > - clocks > - clock-names > -- > 2.30.2 > >
