On 06/05/2022 14:17, Joel Selvaraj wrote: > Add bindings for the EBBG FT8719 6.18" 2246x1080 DSI video mode panel, > which can be found on some Xiaomi Poco F1 phones. The backlight is > managed through the QCOM WLED driver. > > Signed-off-by: Joel Selvaraj <jo@xxxxxxxxxxx> > --- > .../bindings/display/panel/ebbg,ft8719.yaml | 78 +++++++++++++++++++ > 1 file changed, 78 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/ebbg,ft8719.yaml > > diff --git a/Documentation/devicetree/bindings/display/panel/ebbg,ft8719.yaml b/Documentation/devicetree/bindings/display/panel/ebbg,ft8719.yaml > new file mode 100644 > index 000000000000..fac6c9692c55 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/ebbg,ft8719.yaml > @@ -0,0 +1,78 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/panel/ebbg,ft8719.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: EBBG FT8719 MIPI-DSI LCD panel > + > +maintainers: > + - Joel Selvaraj <jo@xxxxxxxxxxx> > + > +description: | > + The FT8719 panel from EBBG is a FHD+ LCD display panel with a resolution > + of 1080x2246. It is a video mode DSI panel. The backlight is managed > + through the QCOM WLED driver. > + > +allOf: > + - $ref: panel-common.yaml# > + > +properties: > + compatible: > + const: ebbg,ft8719 > + > + reg: > + description: DSI virtual channel of the peripheral maxItems > + > + reset-gpios: > + description: phandle of gpio for reset line Skip description - it's obvious. > + > + vddio-supply: > + description: phandle of the Power IC supply regulator s/phandle of// > + > + vddpos-supply: > + description: phandle of the positive boost supply regulator > + > + vddneg-supply: > + description: phandle of the negative boost supply regulator > + > + backlight: true > + port: true Both should not be needed - they come from panel-common.yaml. They might stay in list > + > +required: > + - compatible > + - reg > + - vddio-supply > + - vddpos-supply > + - vddneg-supply > + - reset-gpios > + - port > + > +unevaluatedProperties: false > + > +examples: > + - |+ No need for + > + #include <dt-bindings/gpio/gpio.h> > + dsi0 { Just dsi Best regards, Krzysztof