Hello Laurent, On 5/2/22 18:06, Laurent Pinchart wrote: > Hi Javier, > > Thank you for the patch. > > On Mon, May 02, 2022 at 05:38:58PM +0200, Javier Martinez Canillas wrote: >> The drm_fbdev_generic_setup() function already sets the preferred bits per >> pixel for the device to dev->mode_config.preferred_depth, if preferred_bpp >> value is zero. >> >> Passing the same value to the function is unnecessary. Let's cleanup that >> in the two drivers that do it. > > This looks fine, so > > Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > > but why do we have two different mechanisms to set the preferred depth ? > Could we get all drivers to set dev->mode_config.preferred_depth and Yes, that's the plan and the reason why when we were discussing with Thomas about how to pass this option to the FB helper layer, we agreed on reusing the @preferred_bpp parameter rather than adding a third parameter to drm_fbdev_generic_setup(). Since in the future drivers shouldn't pass that information to the FB helper and just get it from the default mode config. But doing that would require more auditing to all drivers and it could add regressions while patches 1/2 and 2/2 in this series shouldn't cause any behavioral changes. > drop the depth option to drm_fbdev_generic_setup() ? There's a FIXME > comment in drm_fbdev_generic_setup() that could be related. > A FIXME makes sense, I'll add that to when posting a v3. Best regards, Javier Martinez Canillas Linux Engineering Red Hat
