Hi Javier, Thank you for the patch. On Mon, May 02, 2022 at 05:38:58PM +0200, Javier Martinez Canillas wrote: > The drm_fbdev_generic_setup() function already sets the preferred bits per > pixel for the device to dev->mode_config.preferred_depth, if preferred_bpp > value is zero. > > Passing the same value to the function is unnecessary. Let's cleanup that > in the two drivers that do it. This looks fine, so Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> but why do we have two different mechanisms to set the preferred depth ? Could we get all drivers to set dev->mode_config.preferred_depth and drop the depth option to drm_fbdev_generic_setup() ? There's a FIXME comment in drm_fbdev_generic_setup() that could be related. > Signed-off-by: Javier Martinez Canillas <javierm@xxxxxxxxxx> > Reviewed-by: Thomas Zimmermann <tzimmermann@xxxxxxx> > --- > > (no changes since v1) > > drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 2 +- > drivers/gpu/drm/tiny/cirrus.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c > index fe4269c5aa0a..ace92459e462 100644 > --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c > +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c > @@ -349,7 +349,7 @@ static int hibmc_pci_probe(struct pci_dev *pdev, > goto err_unload; > } > > - drm_fbdev_generic_setup(dev, dev->mode_config.preferred_depth); > + drm_fbdev_generic_setup(dev, 0); > > return 0; > > diff --git a/drivers/gpu/drm/tiny/cirrus.c b/drivers/gpu/drm/tiny/cirrus.c > index c8e791840862..ed5a2e14894a 100644 > --- a/drivers/gpu/drm/tiny/cirrus.c > +++ b/drivers/gpu/drm/tiny/cirrus.c > @@ -601,7 +601,7 @@ static int cirrus_pci_probe(struct pci_dev *pdev, > if (ret) > return ret; > > - drm_fbdev_generic_setup(dev, dev->mode_config.preferred_depth); > + drm_fbdev_generic_setup(dev, 0); > return 0; > } > -- Regards, Laurent Pinchart
