On Fri, 25 Mar 2022 at 07:29, Xin Ji <xji@xxxxxxxxxxxxxxxx> wrote: > > On Thu, Mar 24, 2022 at 01:07:56PM +0100, Robert Foss wrote: > > > > > > The driver uses DRM_DEV_* for logs. Can we use this? > > > > > Hi Hsin-Yi, as comment in drm/drm_print.h: > > > > > "NOTE: this is deprecated in favor of drm_dbg". DRM bridge driver not > > > > > use DRM_DEV_* any more. I'll send a patch to replace all of DRM_DEV_* > > > > > later. > > > > > > > > drm_dbg is better than dev_dbg though. With the former, you still get the > > > > option to control it with the drm.debug module parameter, unlike the latter > > > > which normally gets compiled out. > > > > > > > > Please use drm_dbg*. > > > > > > > > ChenYu > > > > > > Hi ChenYu, the parameter of drm_dbg is "drm", if use drm_dbg, it will > > > change more code, I'll consider to upstream new patch to replace all of > > > them later. > > > > > > > Alright, since the driver already uses these logging functions, let's > > apply this patch and fix the logging function this driver uses in a > > separate series. > > > > Xin: Can you submit a patch/series that converts this driver to use > > drm_dbg* functions instead? > Hi Robert Foss, OK, I'll submit patch after this patch get merged. > Thanks, Applied to drm-misc-next. Rob.
