On Tue, Feb 22, 2022 at 10:41:05AM +0200, Mikko Perttunen wrote: > On 2/21/22 22:29, Dmitry Osipenko wrote: > > 18.02.2022 12:31, Mikko Perttunen пишет: > > > On 2/17/22 21:16, Thierry Reding wrote: > > > > ... > > > > > > Reviewed-by: Mikko Perttunen <mperttunen@xxxxxxxxxx> > > > > > > Left one cosmetic comment in the VIC4.0 patch, but overall looks OK. I > > > think it would be fine to have some basic tests in libdrm as well. > > > > There is a question about who is going to use this libdrm API. Are you > > going to use it in the VAAPI driver? > > > > Grate drivers can't use this API because: > > > > 1. More features are needed > > 2. There is no stable API > > 3. It's super painful to keep all drivers and libdrm in sync from a > > packaging perspective. > > > > It's much more practical nowadays to use DRM directly, without > > SoC-specific libdrm API, i.e. to bundle that SoC-specific API within the > > drivers. > > I'm not planning to use this in the VAAPI driver -- I don't personally have > any use case for the libdrm API. As I mentioned, the intention here was to provide a reference implementation along with a simple API that could be used to achieve results in an easy way, without having to do all the buffer tracking for relocations etc. manually. If other projects find this to be useful, that's great (I was thinking of using this to add a few tests to IGT). If they want to use their own constructs, that's absolutely fine, too. Thierry
Attachment:
signature.asc
Description: PGP signature
