18.02.2022 12:31, Mikko Perttunen пишет: > On 2/17/22 21:16, Thierry Reding wrote: >> ... > > Reviewed-by: Mikko Perttunen <mperttunen@xxxxxxxxxx> > > Left one cosmetic comment in the VIC4.0 patch, but overall looks OK. I > think it would be fine to have some basic tests in libdrm as well. There is a question about who is going to use this libdrm API. Are you going to use it in the VAAPI driver? Grate drivers can't use this API because: 1. More features are needed 2. There is no stable API 3. It's super painful to keep all drivers and libdrm in sync from a packaging perspective. It's much more practical nowadays to use DRM directly, without SoC-specific libdrm API, i.e. to bundle that SoC-specific API within the drivers.