On Thu, Jan 27, 2022 at 10:17:13AM +0100, Piotr Oniszczuk wrote: > Sascha, > > FYI > small report regarding 4k modes support in v4: > > -on rk3399 it gives me 4k screen where right vertical 1/3 part of screen is garbage > -on rk3566 my samsung 4k monitor has black screen and cycle of OSD msgs: HDMI2 connected; HDMI2 disconnected; .... Same here on my rk3568, also with a samsung monitor. Was it 4k@60Hz or 4k@30Hz? If the former, could you give 4k@30Hz a try? That mode works well here. > > I would suggest split v4 into 2 separated series: Yeah, splitting up the series makes sense. At the moment I have it all in one series to ease others testing it. Sascha > > -VOP2 support > -HDMI 4k modes support > > BTW: getting well working 4k HDMI modes on rk3399 was real story for me. > There is many different series of patches to address this - but all have some subtle issues for me (i.e. 4k HDMI modes works but i.e. Qt is failing with DRM atomic commits in EGLFS) > I developed well working [1] giving me reliable 4k on rk3399 (including working Qt DRM drawing in EGLFS mode) > Maybe it will be somehow helpful to get 4k modes solution for rk3566 _and_ rk3399 (on single kernel binary)? > > [1] https://github.com/warpme/minimyth2/blob/master/script/kernel/linux-5.16/files/0730-drm-rockchip-add-4k-videomodes-support.patch At least there are patches in it that I have in my series as well and keep popping up everywhere like "drm/rockchip: dw_hdmi: Use auto-generated tables" and "drm/rockchip: dw_hdmi: Set cur_ctr to 0 always" Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
