Hello Thomas, On 1/27/22 10:18, Thomas Zimmermann wrote: > Hi Javier, > > thanks for this patch. > > Acked-by: Thomas Zimmermann <tzimmermann@xxxxxxx> > Thanks! > Find some ideas for consideration below. > [snip] >> + >> +Learning material >> +================= > > Maybe 'External References'. > Agreed, I'll change it. >> + >> +Since the Linux DRM layer supports complex graphics devices, it can be quite >> +overwhelming for newcomers to get familiar with all the needed concepts and >> +learn the subsystem's internals. > > It sounds a bit intimdating to me. Can we give it a positive spin? > Pekka also had reservations about this paragraph, so I think that will just drop it. The goal of having this section was to ease the learning curve but the way I worded it may reinforce the perception that DRM is hard to learn. > IMHO we could add a separate section that talks about complexity and > provides guidelines about how to deal with it: trivial HW? use simple > pipe; dedicated VRAM? try TTM; awkward color formats? see > drm_format_helper.c > Indeed. And we can add such section as a follow-up. Maybe referring to some of the drivers in drivers/gpu/drm/tiny. Best regards, -- Javier Martinez Canillas Linux Engineering Red Hat
